fix: exponential growth of plugin registry in App.init()
#84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| this.registry.push(plugin); | ||
| this.log.debug('plugin %s loaded from %s', plugin.name, file); | ||
| this.log.silly('plugin %s has', plugin.name, plugin.data); | ||
| if (!this.registry.find(p => p.name === plugin.name)) { |
There was a problem hiding this comment.
this can be further optimized so that we don't do this O(n) find but I guess it's good enough :)
rinatkhaziev
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Lando,
Application.init()walks through the plugin registry (app.plugins.registrywhich is a reference tolando.plugins.registry) and invokesPlugin.load()on every plugin that has anapp.jsfile.The side effect of the
Plugin.load()is that it adds every plugin passed to it to the registry. The net effect of this is the growth of the registry: the same plugin may be added several times.Calls to
Lando.getApp()andApp.init()for a different application will double the size of the registry. Because the same plugin will be initialized twice, it will add the same event handlers twice to the application object. This eventually leads to memory leaks and the MaxListenersExceededWarning warning.See: Automattic/vip-cli#2027